Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade version of jackson-databind in sql/core/pom.xml #6028

Closed
wants to merge 1 commit into from
Closed

Upgrade version of jackson-databind in sql/core/pom.xml #6028

wants to merge 1 commit into from

Conversation

tedyu
Copy link
Contributor

@tedyu tedyu commented May 9, 2015

Currently version of jackson-databind in sql/core/pom.xml is 2.3.0

This is older than the version specified in root pom.xml

This PR upgrades the version in sql/core/pom.xml so that they're consistent.

@tedyu
Copy link
Contributor Author

tedyu commented May 9, 2015

This PR should get rid of the following test failure:

https://amplab.cs.berkeley.edu/jenkins/view/Spark/job/Spark-Master-Maven-with-YARN/HADOOP_PROFILE=hadoop-2.4,label=centos/lastCompletedBuild/testReport/test.org.apache.spark.sql/JavaUDFSuite/udf2Test/

java.lang.NoSuchMethodError: com.fasterxml.jackson.databind.introspect.POJOPropertyBuilder.addField(Lcom/fasterxml/jackson/databind/introspect/AnnotatedField;Lcom/fasterxml/ jackson/databind/PropertyName;ZZZ)V
at com.fasterxml.jackson.module.scala.introspect.ScalaPropertiesCollector. com$fasterxml$jackson$module$scala$introspect$ScalaPropertiesCollector$$_addField(ScalaPropertiesCollector.scala:109)
at com.fasterxml.jackson.module.scala.introspect.ScalaPropertiesCollector$$anonfun$_addFields$2$$anonfun$apply$11.apply(ScalaPropertiesCollector.scala:100)

@tedyu
Copy link
Contributor Author

tedyu commented May 9, 2015

@rxin
Please take a look

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 9, 2015

Test build #32303 has started for PR 6028 at commit 28c8394.

@SparkQA
Copy link

SparkQA commented May 9, 2015

Test build #32303 has finished for PR 6028 at commit 28c8394.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32303/
Test PASSed.

@marmbrus
Copy link
Contributor

marmbrus commented May 9, 2015

Thanks for digging into this. Merging to master and 1.4.

asfgit pushed a commit that referenced this pull request May 9, 2015
@tedyu @marmbrus
Upgrade version of jackson-databind in sql/core/pom.xml
6c5b9ff 
Currently version of jackson-databind in sql/core/pom.xml is 2.3.0

This is older than the version specified in root pom.xml

This PR upgrades the version in sql/core/pom.xml so that they're consistent.

Author: tedyu <[email protected]>

Closes #6028 from tedyu/master and squashes the following commits:

28c8394 [tedyu] Upgrade version of jackson-databind in sql/core/pom.xml

(cherry picked from commit 3071aac)
Signed-off-by: Michael Armbrust <[email protected]>
@asfgit asfgit closed this in 3071aac May 9, 2015
@marmbrus
Copy link
Contributor

marmbrus commented May 9, 2015

Actually, why are you hard coding it? Shouldn't it be set to ${fasterxml.jackson.version} so we don't have this problem again?

@pwendell
Copy link
Contributor

Looks like this fixed all of the maven tests - thanks @tedyu!

jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@tedyu @jeanlyn
Upgrade version of jackson-databind in sql/core/pom.xml
ae90da9 
Currently version of jackson-databind in sql/core/pom.xml is 2.3.0

This is older than the version specified in root pom.xml

This PR upgrades the version in sql/core/pom.xml so that they're consistent.

Author: tedyu <[email protected]>

Closes apache#6028 from tedyu/master and squashes the following commits:

28c8394 [tedyu] Upgrade version of jackson-databind in sql/core/pom.xml
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@tedyu @jeanlyn
Upgrade version of jackson-databind in sql/core/pom.xml
011f7b1 
Currently version of jackson-databind in sql/core/pom.xml is 2.3.0

This is older than the version specified in root pom.xml

This PR upgrades the version in sql/core/pom.xml so that they're consistent.

Author: tedyu <[email protected]>

Closes apache#6028 from tedyu/master and squashes the following commits:

28c8394 [tedyu] Upgrade version of jackson-databind in sql/core/pom.xml
@litao-buptsse
Copy link
Contributor

Hi all:
I compiled spark new 1.4 version today. But when I run WordCount demo, it throws NoSuchMethodError "java.lang.NoSuchMethodError: com.fasterxml.jackson.module.scala.deser.BigDecimalDeserializer". Is it related to this issure?

@marmbrus
Copy link
Contributor

NoSuchMethodError generally can't happen if the same jars you compile with
are on the classpath at runtime. I suggest you make sure there aren't
extra jars on your classpath and otherwise ask on the user list.
On Jun 12, 2015 8:30 AM, "Tao Li" [email protected] wrote:

Hi all:
I compiled spark new 1.4 version today. But when I run WordCount demo, it
throws NoSuchMethodError "java.lang.NoSuchMethodError:
com.fasterxml.jackson.module.scala.deser.BigDecimalDeserializer". Is it
related to this issure?

—
Reply to this email directly or view it on GitHub
#6028 (comment).

@litao-buptsse
Copy link
Contributor

I got it. I will check my classpath. Thanks

vanzin
vanzin reviewed Jun 12, 2015
View reviewed changes
sql/core/pom.xml
@@ -64,7 +64,7 @@
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>2.3.0</version>
<version>2.4.4</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this has already been closed, but this version tag should just be removed instead, so that it's inherited from the parent pom.

nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@tedyu @nemccarthy
Upgrade version of jackson-databind in sql/core/pom.xml
0c7c2df 
Currently version of jackson-databind in sql/core/pom.xml is 2.3.0

This is older than the version specified in root pom.xml

This PR upgrades the version in sql/core/pom.xml so that they're consistent.

Author: tedyu <[email protected]>

Closes apache#6028 from tedyu/master and squashes the following commits:

28c8394 [tedyu] Upgrade version of jackson-databind in sql/core/pom.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tedyu @AmplabJenkins @SparkQA @marmbrus @pwendell @litao-buptsse @vanzin